Fix data converter ToPayload error management#2000
Merged
Quinn-With-Two-Ns merged 1 commit intotemporalio:masterfrom Jul 15, 2025
Merged
Fix data converter ToPayload error management#2000Quinn-With-Two-Ns merged 1 commit intotemporalio:masterfrom
Quinn-With-Two-Ns merged 1 commit intotemporalio:masterfrom
Conversation
|
|
|
Cedric Moulard seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
cedricmoulard
force-pushed
the
issue-1999-fix
branch
from
d3e10ae to
1d2c660
Compare
cedricmoulard
force-pushed
the
issue-1999-fix
branch
from
1d2c660 to
6834d80
Compare
Contributor
|
I think this LGTM, what do you think @yuandrew ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Returns error is codec
encodemethod error in ToPayloadWhy?
If codec failed to encode data, the error was silent and the non-encoded payload was return. An error management is missing because an error was expected in this case.
Checklist
Closes DataConverter silent all encoding error #1999
How was this tested: unit test